Error boundary - sentry clean-up #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrepimenta
added
the
needs-dev-review
rickycodes
reviewed
Oct 27, 2020
| @@ -637,7 +637,11 @@ class Onboarding extends PureComponent { | |||
| } | |||
|
|
|||
| const mapStateToProps = state => ({ | |||
| selectedAddress: state.engine.backgroundState.PreferencesController.selectedAddress, | |||
| selectedAddress: | |||
There was a problem hiding this comment.
you could use optional chaining here to achieve the same
rickycodes
approved these changes
Oct 28, 2020
rickycodes
pushed a commit
that referenced
this pull request
Jan 31, 2022
* more sentry cleanup * Optional chaining
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes frequent issues caught by the error boundary. Most of them were already fixed by #1894.
This fixes:
https://sentry.io/organizations/metamask/issues/1953704350/?environment=production&project=2299799&query=is%3Aunresolved+contexts.key%3ATypeError.componentStack&statsPeriod=14d
Code: https://github.com/MetaMask/metamask-mobile/pull/1915/files#diff-4c996ed0fe1a5ee599b3078cfc0d6f716f34cb5bf5af9b5a2f5c442ae4559b27R640
https://sentry.io/organizations/metamask/issues/1882011694/?environment=production&project=2299799&query=is%3Aunresolved+contexts.key%3ATypeError.componentStack&statsPeriod=14d
Code: https://github.com/MetaMask/metamask-mobile/pull/1915/files#diff-583fdf884935e5c408c12fe75e81f217223a9aae96dc99b55a3371e350a28afaR464